xiaobai added a comment. In D72946#1827301 <https://reviews.llvm.org/D72946#1827301>, @teemperor wrote:
> I wish we could do this without a global map. Also the ClangASTImporter > shouldn't have a dependency on Target (I'm actually surprised this compiles > without an additional include). > > I'm not sure where the perfect place for the Target's ClangASTImporter is, > but putting it in the `ClangPersistentVariables` would solve your problem of > getting it out of Target and doesn't need a global map. Also in general the > ClangASTImporter of the Target is used for copying stuff to the scratch > context, so having it in the `ClangPersistentVariables` makes some sense. Oh, yes, I'm not a fan of the global map either. I agree that ClangASTImporter shouldn't depend on Target but I think that's better than the other way around. I also agree that putting it into `ClangPersistentVariables` makes some sense. I'll give it a shot and update this when I get the chance. Thanks for pointing that out! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72946/new/ https://reviews.llvm.org/D72946 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
