labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Yep, looks good.
================
Comment at: lldb/unittests/TestingSupport/SubsystemRAII.h:59
+ /// RAII for a single subsystem.
+ template <typename SubT> struct SubsystemRAIICase {
+
----------------
This doesn't have to be a template since it's already parameterized by the
enclosing `T`. Or, you could actually move it outside the `SubsystemRAII` class
(and possibly into a detail namespace) and save the compiler some work then
Using the same class in different subsystem sequences.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71630/new/
https://reviews.llvm.org/D71630
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
