labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Given the positive response to the RFC, I think we can start landing this stuff. ================ Comment at: lldb/cmake/modules/LLDBConfig.cmake:28 set(default_disable_python OFF) +set(default_disable_lua OFF) set(default_disable_curses OFF) ---------------- JDevlieghere wrote: > mgorny wrote: > > labath wrote: > > > I think this will tick off some bots (and people) because it means that > > > the default configuration will not build unless one has (compatible?) lua > > > installed. Though I don't really like that, the usual way to handle > > > external dependencies in llvm is to detect their presence and > > > automatically disable the relevant functionality. > > > > > > Now, that's not how things work in lldb right now, so it _may_ make sense > > > to do the same for lua (though it also may make sense to port everything > > > to the llvm style). However, the current lldb behavior has been a source > > > of friction in the past and I suspect a fresh build error might reignite > > > some of that. > > > > > > Anyway, you have been warned... > > Fixing this is one of the things at the far end of my todo. If you could > > look into replacing the disable logic with something better, a lot of > > people would really be grateful. > I've changed the default for now and put up an "RFC" here: > https://reviews.llvm.org/D71306 That's cool. I think this can stay as off until we deal with the deal with the dependency problem CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71232/new/ https://reviews.llvm.org/D71232 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
