rupprecht created this revision. rupprecht added a reviewer: echristo. Herald added a reviewer: EricWF. Herald added subscribers: lldb-commits, ldionne. Herald added a project: LLDB. echristo accepted this revision. This revision is now accepted and ready to land.
Speculative fix after 34ef51b5f979 <https://reviews.llvm.org/rG34ef51b5f97933ba12d857d2da8b0d7c133320ce> broke the lldb buildbot on libc++ tests. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71376 Files: lldb/packages/Python/lldbsuite/test/dotest.py Index: lldb/packages/Python/lldbsuite/test/dotest.py =================================================================== --- lldb/packages/Python/lldbsuite/test/dotest.py +++ lldb/packages/Python/lldbsuite/test/dotest.py @@ -856,7 +856,7 @@ with tempfile.NamedTemporaryFile() as f: cmd = [configuration.compiler, "-xc++", "-stdlib=libc++", "-o", f.name, "-"] p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True) - _, stderr = p.communicate("int main() {}") + _, stderr = p.communicate("#include <algorithm>\nint main() {}") if not p.returncode: return True, "Compiling with -stdlib=libc++ works" return False, "Compiling with -stdlib=libc++ fails with the error: %s" % stderr
Index: lldb/packages/Python/lldbsuite/test/dotest.py =================================================================== --- lldb/packages/Python/lldbsuite/test/dotest.py +++ lldb/packages/Python/lldbsuite/test/dotest.py @@ -856,7 +856,7 @@ with tempfile.NamedTemporaryFile() as f: cmd = [configuration.compiler, "-xc++", "-stdlib=libc++", "-o", f.name, "-"] p = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True) - _, stderr = p.communicate("int main() {}") + _, stderr = p.communicate("#include <algorithm>\nint main() {}") if not p.returncode: return True, "Compiling with -stdlib=libc++ works" return False, "Compiling with -stdlib=libc++ fails with the error: %s" % stderr
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits