aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land.
The change looks good with some future refactoring comment inline. ================ Comment at: lldb/source/DataFormatters/FormatManager.cpp:588 + case lldb::eLanguageTypeObjC: + return {lldb::eLanguageTypeObjC, lldb::eLanguageTypeSwift}; case lldb::eLanguageTypeC: ---------------- Unrelated to this change; it seems this should really be a callback into the Language plugin and not hardcoded in LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71316/new/ https://reviews.llvm.org/D71316 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits