This revision was automatically updated to reflect the committed changes. Closed by commit rG2fb07b90dc1c: Remove unsound caching in LanguageCategory (authored by aprantl). Herald added a project: LLDB.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71297/new/ https://reviews.llvm.org/D71297 Files: lldb/source/DataFormatters/LanguageCategory.cpp Index: lldb/source/DataFormatters/LanguageCategory.cpp =================================================================== --- lldb/source/DataFormatters/LanguageCategory.cpp +++ lldb/source/DataFormatters/LanguageCategory.cpp @@ -110,10 +110,6 @@ break; } } - if (match_data.GetTypeForCache() && - (!retval_sp || !retval_sp->NonCacheable())) { - m_format_cache.Set(match_data.GetTypeForCache(), retval_sp); - } return (bool)retval_sp; }
Index: lldb/source/DataFormatters/LanguageCategory.cpp =================================================================== --- lldb/source/DataFormatters/LanguageCategory.cpp +++ lldb/source/DataFormatters/LanguageCategory.cpp @@ -110,10 +110,6 @@ break; } } - if (match_data.GetTypeForCache() && - (!retval_sp || !retval_sp->NonCacheable())) { - m_format_cache.Set(match_data.GetTypeForCache(), retval_sp); - } return (bool)retval_sp; }
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits