aganea added inline comments.

================
Comment at: llvm/lib/Support/Unix/Signals.inc:369
 
-      // Send a special return code that drivers can check for, from 
sysexits.h.
       if (Sig == SIGPIPE)
+        if (auto OldOneShotPipeFunction =
----------------
@vsk Question question: `SIGPIPE` isn't in the `IntSigs` array anymore (you've 
removed it at L209), so the above `std::find` will fail when `Sig == SIGPIPE` 
and this code will never be executed. Most likely this isn't the intended 
behavior, or I am missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70277/new/

https://reviews.llvm.org/D70277



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to