shafik added inline comments.

================
Comment at: lldb/source/Utility/DataExtractor.cpp:595
+      (bitfield_bit_size == 64
+           ? -static_cast<uint64_t>(1)
+           : ((static_cast<uint64_t>(1) << bitfield_bit_size) - 1));
----------------
teemperor wrote:
> How about `std::numeric_limits<uint64_t>::max()`?
Good call, I thought about this change too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70992/new/

https://reviews.llvm.org/D70992



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to