clayborg added a comment.

Although I am ok with this patch, it will only work if the unexpected output 
comes before we expect any packets or perfectly in between packets. Not sure we 
should do this. For example this would work:

  random outut
  Content Length:2
  
  {}

And this would work:

  Content Length:2
  
  {}
  random outut
  Content Length:2
  
  {}

But this wouldn't:

  Content Length:2
  
  random outut
  {}

We could also end up with:

  Content Length:2
  
  
  {random outut}

where "random outut" was written to STDOUT and magically appeared between the 
two braces.

So the main question is:

- do we try and deal with random output being able to be mixed in and have our 
solution only work some of the time
- or just never allow it (current state of things)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70883/new/

https://reviews.llvm.org/D70883



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to