shafik added inline comments.
================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:327
+ bool trySubstitute(llvm::StringRef From, llvm::StringRef To) {
+ if (!llvm::StringRef(this->First, this->numLeft()).startswith(From))
----------------
`trySubstitute` has a return value but it is not used in the code below.
================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:352
+ void appendUnchangedInput() {
+ Result += llvm::StringRef(Written, this->First - Written);
+ Written = this->First;
----------------
`this->First - Written` feels awkward, I feel like given the names they should
be reversed :-(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70721/new/
https://reviews.llvm.org/D70721
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
