clayborg added a comment.
So the main goal here is to let the Architecture plug-in handle the address
masking in all places and make sure there is no code like:
if (ArchSpec arch = m_objfile_sp->GetArchitecture()) {
if (arch.GetTriple().getArch() == llvm::Triple::arm ||
arch.GetTriple().getArch() == llvm::Triple::thumb)
return ~1ull;
}
anywhere in the codebase. Otherwise when we add a new architecture that
requires bit stripping/adding, we end up having to change many locations in the
code (2 of which were added with this patch). So use the Architecture plug-in
to do this and we just need to edit the Architecture plug-in code for each
architecture.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70840/new/
https://reviews.llvm.org/D70840
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
