JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lldb/source/Symbol/ClangASTContext.cpp:8462
+ ClangASTContext::SetMetadata(clang_ast, getter, *metadata);
+ getter->setMethodParams(*clang_ast,
llvm::ArrayRef<clang::ParmVarDecl *>(),
----------------
The indentation here seems off?
================
Comment at: lldb/source/Symbol/ClangASTContext.cpp:8961
+ if (auto *objc_obj = llvm::dyn_cast<clang::ObjCObjectType>(
+ ClangUtil::GetQualType(full_type).getTypePtr()))
+ if (clang::ObjCInterfaceDecl *interface_decl = objc_obj->getInterface())
{
----------------
I think adding braces here would help readability.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70580/new/
https://reviews.llvm.org/D70580
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
