labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good to me
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:215-220
+ if (reginfo->byte_offset + reginfo->byte_size
+ <= buffer_sp->GetByteSize()) {
+ m_reg_valid[i] = true;
+ } else {
+ m_reg_valid[i] = false;
+ }
----------------
maybe just `m_reg_valid[i] = reginfo->byte_offset + reginfo->byte_size <=
buffer_sp->GetByteSize()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70417/new/
https://reviews.llvm.org/D70417
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
