teemperor added a comment.

You could make a PR with both this commit and the test against the swift fork. 
If that is accepted and merged, then the fix can be upstreamed. But having a 
test for this upstream is what should ideally happen instead of just testing 
this downstream.



================
Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:662
 
+static void NSURL_ConcatSummary(StreamString &first, const StreamString 
&second,
+    std::string prefix, std::string suffix) {
----------------
I am not a big fan of the "Class_method" way of extending classes. Maybe 
`ConcatSummaryForNSURL`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70393/new/

https://reviews.llvm.org/D70393



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to