krytarowski added inline comments.
================
Comment at: lldb/source/Plugins/Process/NetBSD/NativeThreadNetBSD.cpp:122
+ if (::sysctl(mib, 5, nullptr, &size, nullptr, 0) == -1 || size == 0) {
+ LLDB_LOG(log, "sysctl() for LWP info size failed: {0}", strerror(errno));
+ return "";
----------------
labath wrote:
> Thread-safety technically doesn't matter in this part of the code, but I
> think it would be good practice to use `llvm::StrError`
> (`llvm/Support/Errno.h`) anyway.
`strerror` is thread safe on NetBSD, but probably better to pick llvm
interfaces.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70363/new/
https://reviews.llvm.org/D70363
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
