JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
In D70137#1743032 <https://reviews.llvm.org/D70137#1743032>, @rupprecht wrote: > In D70137#1742766 <https://reviews.llvm.org/D70137#1742766>, @JDevlieghere > wrote: > > > This is very nice, thanks! > > > > Any chance we could test this with a pexpect test? > > > Absolutely. It was waaay more complicated than I expected due to funny > escaping somewhere between pexpect and lldb, but testing an actual command > seems to work. Hopefully I've captured that in the test doc comment. Ha, I can imagine... Thanks for taking the time to make it work! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70137/new/ https://reviews.llvm.org/D70137 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
