labath added a comment. In D69503#1726823 <https://reviews.llvm.org/D69503#1726823>, @mstorsjo wrote:
> What's the correct course of action here? Remove the `m_session_data.reset()` > from ProcessWindows::OnExitProcess, concluding that it's up to some other > class to clear `m_session_data` in this case? I'm not really familiar with this code, but removing the reset() call does not sound completely unreasonable to me. I think the only one who may have enough context here is @amccarth, so maybe let's wait if he has to say anything? (Ideally, I'd just delete ProcessWindows entirely, and move everything to lldb-server based model -- it's much easier to reason about threads there) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69503/new/ https://reviews.llvm.org/D69503 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
