labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks fine, though I'd try to remove the `extern "C"` thingy to avoid the need
to supress warnings and stuff...
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:76-79
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wreturn-type-c-linkage"
+
+extern "C" llvm::Expected<bool> LLDBSwigPythonBreakpointCallbackFunction(
----------------
How sure are we that these functions need to be `extern "C"` ? AFAICT, the only
requirement is that they match the declarations in ScriptInterpreterPython.cpp.
That can be easily achieved by just removing `extern "C"` from both
declarations.
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:2283
+ [&](PythonException &E) {
+ debugger.GetErrorStream() << E.ReadBacktrace();
+ },
----------------
Random idea: Should we make `PythonException::message()` include the backtrace?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69468/new/
https://reviews.llvm.org/D69468
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
