labath added a comment.

I am not thrilled by all of that duping going around. Having multiple FILE 
objects means that you have multiple independent file caches too. That can 
cause different kinds of strange behavior if multiple things start 
reading/writing to the different FILE objects simultaneously. I think I'd 
rather just keep the existing borrow semantics. I don't think that should be a 
problem in practice -- it's just that this test is weird because is testing the 
extreme cases of this behavior (which is fine). Normally you'll just use one 
level of wrapping and so the underlying file will be naturally kept around, 
since lldb will still be holding onto it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69488/new/

https://reviews.llvm.org/D69488



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to