hhb added a comment.

In D69019#1722063 <https://reviews.llvm.org/D69019#1722063>, @labath wrote:

> Right. I see what you mean.
>
> But... does this have to happen at build time? Since the list of files is 
> already known at configuration time, you should be able to generate the files 
> in the "cmake" step (but still leave the copying for the build step, so that 
> any changes to the files are reflected in rebuilds).
>
> (I'm not insisting on that -- I think that the current patch is already much 
> better than what we had before. If you think that the python script is better 
> than that, feel free to say so.)


That could be done... Except that the path of these files can be determined at 
build time, at least for multi-configuration generators. So we may need to 
write them to a temporary path at configuration time, and copy them to the 
right Debug / Release directory at build time.

Yea let's use python for now... 😊


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69019/new/

https://reviews.llvm.org/D69019



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to