labath added a comment. In D68549#1710744 <https://reviews.llvm.org/D68549#1710744>, @llunak wrote:
> Thinking more about this, maybe this is really not the right place and the > change should be done in BumpPtrAllocator? To me it seems rather unreasonable > that it would double the allocation size only after 128 allocations. Surely > by the time it has already allocated 128*4096=0.5MiB memory it could have > decided to raise the allocation size much sooner? That is my impression as well, but beware that BumpPtrAllocator has many users, and a they are generally more performance-sensitive and better tuned than lldb, so it may turn out that this value actually *is* the sweet spot for something. Nevertheless, I think it's worth asking around or trying to send a patch. However, independently of that, I think it would make sense to raise the initial allocation size in ConstString somewhat (just not straight to 1 (256) meg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68549/new/ https://reviews.llvm.org/D68549 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
