labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:781 + with open(self.out_filename, 'r') as f: + # python2 returns None from write, python3 returns 7 + lines = [x for x in f.read().strip().split() if x != "7"] ---------------- lawrence_danna wrote: > labath wrote: > > I find this comment confusing. Does that refer to the write call above? If > > so, I don't see how that is relevant here.. > When we check the output on the next line we have to strip out the 7, which > is the number of bytes written. Ah, right. Thanks for clearing that up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68737/new/ https://reviews.llvm.org/D68737 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
