clayborg added a comment. > The only place where I treat the extra_args as a Dictionary is when I use as > a way to tell whether the extra_args is empty, which I need to write the > right wrapper function in GenerateBreakpointCommandCallbackData. That > function is little annoying because it doesn't know whether it is calling a > function or some text gotten from the I/O handler, so I can't count the > function arguments there to decide which signature to use. > > Let me see if I can make this cleaner so I don't have to rely on that. I > really don't intend to limit fancier uses of the extra args.
Let me know if you are going to look into making this cleaner for this patch. If so, I will hold off, else I can accept if you are out of time Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68671/new/ https://reviews.llvm.org/D68671 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
