labath added subscribers: jankratochvil, kwk.
labath added a comment.
I don't know much about this stuff, but it seems relatively reasonable to me.
Tagging @kwk and @jankratochvil because they were involved in some elf symbol
merging discussions recently, and so they may find this interesting.
================
Comment at: lldb/lit/ObjectFile/Inputs/SymbolTable.yaml:1
+--- !mach-o
+FileHeader:
----------------
Somewhat confusingly, the "object file" tests currently live in
`lit/Modules/$OBJ_FORMAT`. In the current arrangement, I believe this should go
there too, but if you want to rename the whole `Modules` folder into
`ObjectFile`, I would be fine with that.
================
Comment at: lldb/lit/ObjectFile/TestSymbolTable.test:1
+# REQUIRES: system-darwin
+
----------------
Is that necessary? I believe our MachO capabilities should work fine
everywhere. At least, it doesn't seem to be necessary for all (four) of our
existing MachO obj file tests.
================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:3695
+ bool debug_only) {
+ const bool is_debug = ((nlist.n_type & N_STAB) != 0);
+ if (is_debug != debug_only)
----------------
Personally, I'd just move this check out of the lambda and into the code which
invokes it.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68536/new/
https://reviews.llvm.org/D68536
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
