lawrence_danna added a comment. In D68188#1695069 <https://reviews.llvm.org/D68188#1695069>, @labath wrote:
> I agree about the separate patch stuff, but it seems to be that this should > be done before this one. After all, all (most?) of the existing code has > already been DataObject-ized and this patch is the thing that's deviating > from that practice. I don't think you should rewrite all of the existing code > -- hopefully we can find a way to fit this in there. Yea... I tried updating all the PythonDataObjects code to use Errors and Expected<> and it wound up being just way too big of a patch. I've updated this patch to add a giant warning at the top of PythonDataObjects.h about the dangers, as well adding just enough Expected<> support to do what I need for this patch. How's it look now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
