rupprecht added a comment. In D68299#1692503 <https://reviews.llvm.org/D68299#1692503>, @labath wrote:
> > FYI, we've root caused some internal lldb asan failures to this patch. I > > don't have a repro yet (my lldb tests seem to be failing locally for > > unrelated reasons) > > This should be fixed with r373572. Thanks! > BTW, are you sure those reasons were unrelated? If you have had nearly every > test failing then it was very likely due to this. (The reason only a couple > of tests failed for you in asan mode is because our CI does not run a large > chunk of the lldb tests... :/ ) Yes, tests are still failing locally for me, e.g. `Driver/TestConvenienceVariables.test` in `ninja check-lldb-driver` fails: Command Output (stderr): -- Traceback (most recent call last): File "<string>", line 1, in <module> ImportError: No module named lldb.embedded_interpreter Traceback (most recent call last): File "<string>", line 1, in <module> NameError: name 'run_one_line' is not defined Traceback (most recent call last): File "<string>", line 1, in <module> NameError: name 'run_one_line' is not defined Traceback (most recent call last): File "<string>", line 1, in <module> NameError: name 'run_one_line' is not defined Traceback (most recent call last): File "<string>", line 1, in <module> NameError: name 'run_one_line' is not defined Traceback (most recent call last): File "<string>", line 1, in <module> NameError: name 'run_one_line' is not defined Traceback (most recent call last): File "<string>", line 1, in <module> NameError: name 'run_one_line' is not defined error: python failed attempting to evaluate 'print(lldb.debugger)' I think it's a python-related misconfiguration somewhere about not finding the lldb module, but I'm not sure when it started -- these tests used to pass, but I nuked my cmake tree and apparently didn't reconfigure it correctly. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68299/new/ https://reviews.llvm.org/D68299 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits