teemperor created this revision.
teemperor added reviewers: JDevlieghere, labath.
Herald added subscribers: lldb-commits, abidh, mgorny.
Herald added a project: LLDB.
We mark debugserver_vers.c as a generated file in CMake. This means that when
we run `ninja clean` we end up deleting that file,
but any following `ninja` invocation will fail due to the file missing. The
file can't be generated as `ninja` doesn't know it has to
rerun CMake to create the file. Turns out that marking the output of
configure_file as generated is wrong as explained in this bug report:
https://gitlab.kitware.com/cmake/cmake/issues/18032
This patch just removes that property. The only side effect of this seems to be
that this file maybe shows up in your IDE when
opening our CMake project, but that seems like a small sacrifice.
This patch can be quickly tested by running `ninja clean ; ninja
lldbDebugserverCommon`. Before this patch the build will fail
due to debugserver_vers.c missing.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D68376
Files:
lldb/tools/debugserver/source/CMakeLists.txt
Index: lldb/tools/debugserver/source/CMakeLists.txt
===================================================================
--- lldb/tools/debugserver/source/CMakeLists.txt
+++ lldb/tools/debugserver/source/CMakeLists.txt
@@ -136,7 +136,6 @@
)
set(DEBUGSERVER_VERS_GENERATED_FILE
${CMAKE_CURRENT_BINARY_DIR}/debugserver_vers.c)
-set_source_files_properties(${DEBUGSERVER_VERS_GENERATED_FILE} PROPERTIES
GENERATED 1)
configure_file(debugserver_vers.c.in
${DEBUGSERVER_VERS_GENERATED_FILE} @ONLY)
Index: lldb/tools/debugserver/source/CMakeLists.txt
===================================================================
--- lldb/tools/debugserver/source/CMakeLists.txt
+++ lldb/tools/debugserver/source/CMakeLists.txt
@@ -136,7 +136,6 @@
)
set(DEBUGSERVER_VERS_GENERATED_FILE ${CMAKE_CURRENT_BINARY_DIR}/debugserver_vers.c)
-set_source_files_properties(${DEBUGSERVER_VERS_GENERATED_FILE} PROPERTIES GENERATED 1)
configure_file(debugserver_vers.c.in
${DEBUGSERVER_VERS_GENERATED_FILE} @ONLY)
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
