guiandrade added a comment. In D67022#1660979 <https://reviews.llvm.org/D67022#1660979>, @clayborg wrote:
> In D67022#1660945 <https://reviews.llvm.org/D67022#1660945>, @guiandrade > wrote: > > > In D67022#1660901 <https://reviews.llvm.org/D67022#1660901>, @clayborg > > wrote: > > > > > This looks like a good approach to me. Pavel? > > > > > > Even without tests? Just to clarify my last comment, I could not find a way > > to use the command "target modules dump as" to ensure we won't have a > > regression in the future. Apparently, with or without the extra calls, that > > command's output looks the same. > > > I would prefer to have tests. I was just saying that the code looked good, > and it is now time to proceed with finding a way to test. Oh, got it. Thanks for the clarification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67022/new/ https://reviews.llvm.org/D67022 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
