clayborg added inline comments.
================
Comment at: source/Plugins/Process/Utility/RegisterContextLLDB.cpp:1875
+ if (addr.SetLoadAddress(candidate, &process.GetTarget()) &&
+ addr.GetSection()->GetPermissions() & lldb::ePermissionsExecutable) {
+ address = candidate_addr;
----------------
WE should probably be using the memory region permissions using:
```
bool Process::GetLoadAddressPermissions(lldb::addr_t load_addr, uint32_t
&permissions);
```
Why? You might have a stack going through JIT'ed code that might not have a
section. But the memory region info will know about the permissions.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66638/new/
https://reviews.llvm.org/D66638
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
