labath marked an inline comment as done.
labath added inline comments.

================
Comment at: lldb/lit/Breakpoint/minidebuginfo-corrupt-xz.yaml:13
+
+# RUN: %lldb -x -b -o 'image dump symtab' %t.obj 2>&1 | FileCheck %s
+
----------------
labath wrote:
> You shouldn't need an explicit `-x` in these tests as %lldb adds 
> `--no-use-colors` already.
Actually, I take this back. It seems %lldb does not pass this automatically. I 
am not sure why, but since colors aren't a problem you here, you probably don't 
have to explicitly disable them anyway...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66791/new/

https://reviews.llvm.org/D66791



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to