aprantl added a comment. > Looks good overall. Just a question of it we want to return "const > LanguageSet &" to avoid copies. Also switch static functions that currently > return "LanguageSet" over to use static variables and llvm::once to init them > and then return "const LanguageSet &".
The point of the static_assert in TypeSystem.cpp is to make sure that a LanguageSet is exactly 64 bits in size so it is cheap to pass it by value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66546/new/ https://reviews.llvm.org/D66546 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
