I've reverted the debugserver change in r369621 because it doesn't link against llvm and was therefore failing to build on the bot.
On Wed, Aug 21, 2019 at 8:18 PM Davide Italiano via Phabricator via lldb-commits <lldb-commits@lists.llvm.org> wrote: > > This revision was not accepted when it landed; it landed in state "Needs > Review". > This revision was automatically updated to reflect the committed changes. > Closed by commit rL369618: [lldb] Replace std::once_flag with > llvm::once_flag. (authored by davide, committed by ). > Herald added a project: LLVM. > Herald added a subscriber: llvm-commits. > > Changed prior to commit: > https://reviews.llvm.org/D66566?vs=216521&id=216546#toc > > Repository: > rL LLVM > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D66566/new/ > > https://reviews.llvm.org/D66566 > > Files: > lldb/trunk/include/lldb/Target/Process.h > lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp > > > Index: > lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp > =================================================================== > --- > lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp > +++ > lldb/trunk/tools/debugserver/source/MacOSX/DarwinLog/DarwinLogCollector.cpp > @@ -46,7 +46,7 @@ > s_os_activity_stream_set_event_handler; > > bool LookupSPICalls() { > - static std::once_flag s_once_flag; > + static llvm::once_flag s_once_flag; > static bool s_has_spi; > > std::call_once(s_once_flag, [] { > Index: lldb/trunk/include/lldb/Target/Process.h > =================================================================== > --- lldb/trunk/include/lldb/Target/Process.h > +++ lldb/trunk/include/lldb/Target/Process.h > @@ -50,6 +50,7 @@ > #include "lldb/lldb-private.h" > > #include "llvm/ADT/ArrayRef.h" > +#include "llvm/Support/Threading.h" > #include "llvm/Support/VersionTuple.h" > > namespace lldb_private { > @@ -2741,7 +2742,7 @@ > enum { eCanJITDontKnow = 0, eCanJITYes, eCanJITNo } m_can_jit; > > std::unique_ptr<UtilityFunction> m_dlopen_utility_func_up; > - std::once_flag m_dlopen_utility_func_flag_once; > + llvm::once_flag m_dlopen_utility_func_flag_once; > > size_t RemoveBreakpointOpcodesFromBuffer(lldb::addr_t addr, size_t size, > uint8_t *buf) const; > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
