jankratochvil marked 8 inline comments as done. jankratochvil added inline comments.
================ Comment at: lldb/include/lldb/Utility/RegularExpression.h:34 + /// \param[in] string + /// A NULL terminated C string that represents the regular + /// expression to compile. ---------------- labath wrote: > Null terminated? I hope not.. Updated+added: ``` + /// An llvm::StringRef that represents the regular expression to compile. + // String is not referenced anymore after the object is constructed. ``` ================ Comment at: lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:445 RegularExpression regex; llvm::SmallVector<llvm::StringRef, 4> matches; ---------------- labath wrote: > Here I'd just declare a fresh variable in each of the blocks instead of > continuously recycling this one. Rather dropped the variable. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66392/new/ https://reviews.llvm.org/D66392 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
