labath added subscribers: stella.stamenova, labath.
labath added a comment.

I agree that the USE variables seem redundant. I remember thinking the same 
thing when they were introduced, but I was not objecting back then because 
there seemed to be a good reason for it. However, now I don't know what that 
reason was... Tagging @stella.stamenova in case she does (I know it had 
something to do with multi-config generators and visual studio).

That said, I'm not a fan of force-overwriting cache variables specified by the 
user, particularly when the same effect can be achieved by *deleting* the cache 
variable instead of setting it to an empty string. I think you should be able 
to reset the default value of `LLDB_TEST_C_COMPILER` (just like any other cmake 
variable) by running `cmake -ULLDB_TEST_C_COMPILER`. You can even delete both 
variables at once with `-ULLDB_TEST_*_COMPILER`.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66429/new/

https://reviews.llvm.org/D66429



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to