JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
LGTM with the inline comment.
================
Comment at: lldb/include/lldb/Utility/StringList.h:26
class StringList {
+ typedef std::vector<std::string> StorageType;
+
----------------
This typedef is commonly `collection` in LLDB [1]. I think we should do the
same here for consistency.
[1] See `TypeMap.h`, `Value.h`, `QueueList.h` etc
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66345/new/
https://reviews.llvm.org/D66345
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
