JDevlieghere requested changes to this revision.
JDevlieghere added a comment.
This revision now requires changes to proceed.

I agree with Reid, change looks fine but this definitely needs a test.

The Python-style tests in `packages/Python/lldbsuite/test` give you the most 
freedom as they use makefiles to build inferiors, but a lit test might be 
easier and less boilerplate.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65826/new/

https://reviews.llvm.org/D65826



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to