jankratochvil marked 3 inline comments as done.
jankratochvil added inline comments.
================
Comment at:
lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestNoWatchpointSupportInfo.py:24
return "T02thread:1ff0d;thread-pcs:10001bc00;"
+ return ""
----------------
Here it was always timing out (and still reporting `PASS`) which was not a
problem for 5 seconds timeout but with 5 minutes timeout it was hanging during
the testsuite run.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:214
+ // 6 secs are still not sufficient; this line is not to be checked-in.
ScopedTimeout timeout(*this, std::max(GetPacketTimeout(), seconds(6)));
----------------
The failed `TestGDBRemoteClient` testcases did timeout despite this increase to
6 seconds (which made more sense before rL357954 when the default timeout was
just 1 second and not the current 5 seconds).
If this patch is not welcome maybe we could try running the testsuite just
increasing this `seconds(6)` to some `seconds(60)`.
================
Comment at: lldb/tools/lldb-test/lldb-test.cpp:984
+ "settings set plugin.process.gdb-remote.packet-timeout 300",
+ /*add_to_history*/ eLazyBoolNo, Result);
----------------
I somehow failed to find how to access the timeout by API, I can try again.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65271/new/
https://reviews.llvm.org/D65271
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
