teemperor added a comment.

> I don't see any way to test this as the *multiline* expression completion is 
> completely untested at the moment and I don't think we have any existing code 
> for testing infrastructure for it.

Correct me if I'm wrong with this. I know we never test this functionality (as 
the whole IOHandler business is tricky to test), but I'm not sure if we maybe 
have some funky way around it.

Otherwise I would say we merge this as-is, as I don't want to have an obvious 
bug around until we find a method to test the interactive IO code.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64995/new/

https://reviews.llvm.org/D64995



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to