JDevlieghere created this revision.
JDevlieghere added a reviewer: sgraenitz.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.
I'm pretty sure there's no need to have this logic living in LLDBStandalone. We
always go through `LLDBConfig.cmake` which has the canonical way to find the
Python libs and interpreter.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D64821
Files:
lldb/cmake/modules/LLDBStandalone.cmake
Index: lldb/cmake/modules/LLDBStandalone.cmake
===================================================================
--- lldb/cmake/modules/LLDBStandalone.cmake
+++ lldb/cmake/modules/LLDBStandalone.cmake
@@ -87,18 +87,6 @@
include(CheckAtomic)
include(LLVMDistributionSupport)
- set(Python_ADDITIONAL_VERSIONS 3.7 3.6 3.5 2.7)
- if (PYTHON_EXECUTABLE STREQUAL "")
- include(FindPythonInterp)
- if( NOT PYTHONINTERP_FOUND )
- message(FATAL_ERROR
- "Unable to find Python interpreter, required for builds and
testing.
- Please install Python or specify the PYTHON_EXECUTABLE CMake
variable.")
- endif()
- else()
- message(STATUS "Found PythonInterp: ${PYTHON_EXECUTABLE}")
- endif()
-
set(PACKAGE_VERSION "${LLVM_PACKAGE_VERSION}")
set(LLVM_INCLUDE_TESTS ON CACHE INTERNAL "")
Index: lldb/cmake/modules/LLDBStandalone.cmake
===================================================================
--- lldb/cmake/modules/LLDBStandalone.cmake
+++ lldb/cmake/modules/LLDBStandalone.cmake
@@ -87,18 +87,6 @@
include(CheckAtomic)
include(LLVMDistributionSupport)
- set(Python_ADDITIONAL_VERSIONS 3.7 3.6 3.5 2.7)
- if (PYTHON_EXECUTABLE STREQUAL "")
- include(FindPythonInterp)
- if( NOT PYTHONINTERP_FOUND )
- message(FATAL_ERROR
- "Unable to find Python interpreter, required for builds and testing.
- Please install Python or specify the PYTHON_EXECUTABLE CMake variable.")
- endif()
- else()
- message(STATUS "Found PythonInterp: ${PYTHON_EXECUTABLE}")
- endif()
-
set(PACKAGE_VERSION "${LLVM_PACKAGE_VERSION}")
set(LLVM_INCLUDE_TESTS ON CACHE INTERNAL "")
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
