JDevlieghere updated this revision to Diff 208235.
JDevlieghere added a comment.
Add comments with the exact wording from the docs.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64267/new/
https://reviews.llvm.org/D64267
Files:
lldb/source/Utility/LLDBAssert.cpp
Index: lldb/source/Utility/LLDBAssert.cpp
===================================================================
--- lldb/source/Utility/LLDBAssert.cpp
+++ lldb/source/Utility/LLDBAssert.cpp
@@ -21,6 +21,12 @@
if (LLVM_LIKELY(expression))
return;
+ // In a Debug configuration lldb_assert() behaves like assert().
+ assert(false && "lldb_assert failed");
+
+ // In a Release configuration it will print a warning and encourage the user
+ // to file a bug report, similar to LLVM’s crash handler, and then return
+ // execution.
errs() << format("Assertion failed: (%s), function %s, file %s, line %u\n",
expr_text, func, file, line);
errs() << "backtrace leading to the failure:\n";
Index: lldb/source/Utility/LLDBAssert.cpp
===================================================================
--- lldb/source/Utility/LLDBAssert.cpp
+++ lldb/source/Utility/LLDBAssert.cpp
@@ -21,6 +21,12 @@
if (LLVM_LIKELY(expression))
return;
+ // In a Debug configuration lldb_assert() behaves like assert().
+ assert(false && "lldb_assert failed");
+
+ // In a Release configuration it will print a warning and encourage the user
+ // to file a bug report, similar to LLVM’s crash handler, and then return
+ // execution.
errs() << format("Assertion failed: (%s), function %s, file %s, line %u\n",
expr_text, func, file, line);
errs() << "backtrace leading to the failure:\n";
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
