jingham requested changes to this revision.
jingham added inline comments.
This revision now requires changes to proceed.
================
Comment at: source/Core/ValueObject.cpp:1706-1708
+ for (auto *runtime : process->GetLanguageRuntimes()) {
+ if (runtime->IsWhitelistedRuntimeValue(GetName()))
+ return false;
----------------
clayborg wrote:
> davide wrote:
> > clayborg wrote:
> > > Still seems weird that any language can white list a variable by name.
> > > Say swift has a variable named "this" which is truly should be hidden and
> > > is marked as artificial, we will always show it...
> > Swift has no `this`, it has `self`. And yes, there are many places in the
> > debugger where `self` is mentioned explicitly by name and has special
> > handling. Also, I think we want to show it, most of the times.
> Exactly Davide. **Any** language can whitelist **any** variable they want for
> **any** other language regardless of the language of origin of the current
> ValueObject.
I agree with Greg. Otherwise various languages are going to fight about their
respective white lists. We should really get the ValueObject's runtime
language with ValueObject::GetObjectRuntimeLanguage() and then asking that
runtime.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63240/new/
https://reviews.llvm.org/D63240
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
