mgorny marked 2 inline comments as done.
mgorny added a comment.
In D63610#1553143 <https://reviews.llvm.org/D63610#1553143>, @labath wrote:
> It's not much, but it definitely does help.
>
> > // NB: I have no clue why FreeBSD code claims to belong in 'POSIX', and
> > Linux does not.
>
> I think that somehow fell out of the fact that FreeBSD uses an in-process
> debugging plugin, while linux uses lldb-server.
Ok, then I probably don't have to worry about porting NetBSD to reuse that
stuff ;-).
================
Comment at: lldb/source/Plugins/Process/Utility/RegisterContext_x86.h:357
+// Convenience function to combine YMM register data from XSAVE-style input.
+inline YMMReg XStateToYMM(const void* xmm_bytes, const void* ymm_bytes) {
+ YMMReg ret;
----------------
labath wrote:
> maybe call the last arg `ymmh_bytes` ?
Makes sense.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63610/new/
https://reviews.llvm.org/D63610
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
