mgorny added a comment.

In D63594#1551702 <https://reviews.llvm.org/D63594#1551702>, @labath wrote:

> BTW, is ReadGPR even called from some other place than 
> `NativeRegisterContextNetBSD_x86_64::ReadRegisterSet` ? If not, then we could 
> remove all of these functions (except the `ReadRegisterSet` I suggest above), 
> and inline everything into 
> `NativeRegisterContextNetBSD_x86_64::ReadRegisterSet` (one of these should be 
> renamed, obviously), removing about 5 layers of indirection...


I think the idea is that they will be reused when we introduce additional 
architectures.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63594/new/

https://reviews.llvm.org/D63594



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to