hintonda added inline comments.
================ Comment at: lldb/trunk/unittests/tools/lldb-mi/utils/CMakeLists.txt:12 + +target_sources(LLDBMiUtilTests PRIVATE $<TARGET_OBJECTS:lldb-mi-utils>) ---------------- tatyana-krasnukha wrote: > hintonda wrote: > > Just wanted to let you know that using `$<TARGET_OBJECTS:...>` in anything > > other than `add_library` and `add_executable` wasn't added until cmake 3.9, > > so I'm unable to configure lldb using the officially supported cmake 3.4.3 > > version. > > > > Btw, I use cmake 3.4.3 locally so I don't unintentionally use new > > unsupported features to the clang/llvm cmake files. > > > Thank you for pointing to this issue. I had cmake 3.6.2 version installed > and, oddly enough, it worked well. > I'd appreciate your review of the [[https://reviews.llvm.org/D63544 | patch > ]] that fixes the issue. I don't have all the various version installed, so I was trying to figure out which version by looking at the online docs. If 3.6.2 works, then it changed somewhere between 3.4.3 and 3.6.2, so I guess you can just use >= 3.6.2 for your test. Thanks again for looking into this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55653/new/ https://reviews.llvm.org/D55653 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
