aprantl added inline comments.
================
Comment at: lldb/include/lldb/Utility/Reproducer.h:114
+struct VersionInfo {
+ static const char *name;
----------------
Isn't a struct with two static members basically a namespace? I'm curious, I
have not seen this pattern before.
================
Comment at: lldb/include/lldb/Utility/Reproducer.h:119
+
+class VersionProvider : public Provider<VersionProvider> {
+public:
----------------
Doxygen comments?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63229/new/
https://reviews.llvm.org/D63229
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
