labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks fine to me. Thank you for fixing this. ================ Comment at: lldb/unittests/Host/SocketTestUtilities.cpp:16 +namespace { +void AcceptThread(Socket *listen_socket, bool child_processes_inherit, + Socket **accept_socket, Status *error) { ---------------- LLVM prefers static functions over ones in anonymous namespaces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61833/new/ https://reviews.llvm.org/D61833 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits