labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

The fix looks good, but it seems like it wouldn't be hard to make the test 
windows-compatible, so I think we should do that. All it would take is to 
compile a very dumb version of "env" which just prints the value of the single 
env var. If you can get it to print in a different format then you can also 
avoid the double quote trick (which also doesn't work on windows).

Also, doesn't debugging of /usr/bin/env fail on darwin with SIP ?


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61864/new/

https://reviews.llvm.org/D61864



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to