aprantl added inline comments.
================
Comment at: source/Target/CPPLanguageRuntime.cpp:217
if (symbol != NULL &&
symbol->GetName().GetStringRef().contains("__invoke")) {
----------------
davide wrote:
> This should probably be `nullptr`, anyway, my general comment is that this
> check is scattered all around the function and could be centralized in a
> single place.
`if (symbol && symbol->GetName() ....`
================
Comment at: source/Target/CPPLanguageRuntime.cpp:264
(symbol != nullptr &&
symbol->GetName().GetStringRef().contains("__invoke"))) {
// Case 1 and 2
----------------
this should probably be factored out into a bool variable.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61805/new/
https://reviews.llvm.org/D61805
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
