teemperor added inline comments.
================ Comment at: packages/Python/lldbsuite/test/expression_command/argument_passing_restrictions/main.cpp:40 + return Shape::empty_shape()->bounds().x; // break here +} ---------------- Some small things: 1. I think the source here is not clang-formatted :) 2. It's not really clear to me if Shape or Bounds are supposed to have arg passing restrictions (or both?). Maybe rename them or comment this in the source. E.g. `// supposed to be passed by ref/value`. 3. Can this test be more minimized? Do we need both x and y as member variables? Do we need all these methods and variables? Especially when debug stepping through this test case at some point a minimized test case is always nicer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/ https://reviews.llvm.org/D61146 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
