amccarth accepted this revision. amccarth added a comment. LGTM, but I found one comment a bit confusing for me.
================ Comment at: source/Symbol/PostfixExpression.cpp:150 + /// InitialValueNodes in our input expression, we assume the initial stack + /// will contain their value (hence we start with m_stack_depth = 1). If we + /// don't have InitialValueNodes, this value is not used, and so its starting ---------------- I'm having trouble understanding this comment. "will contain their value" -- What does "their" refer to here? I guessed InitialValueNodes, but then I'd expect "value" to be "values" (plural), and I'm not sure how that relates to the stack depth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61183/new/ https://reviews.llvm.org/D61183 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
